Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up build client performance #575

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Speed up build client performance #575

merged 4 commits into from
Dec 18, 2024

Conversation

nplasterer
Copy link
Contributor

Much much faster now by passing in the apiClient.

Performance Comparison: iOS vs Android

Metric Android (ms) iOS (ms) Difference (ms) Faster Platform
Created a new client 1610.02 1554.35 55.67 iOS
Built a client 606.24 631.59 25.35 Android
Built a client with inboxId 122.83 109.19 13.64 iOS
Created a client after connecting to backend 1116.84 1062.09 54.75 iOS

@nplasterer nplasterer self-assigned this Dec 18, 2024
@nplasterer nplasterer requested a review from a team as a code owner December 18, 2024 20:26
Copy link

changeset-bot bot commented Dec 18, 2024

🦋 Changeset detected

Latest commit: 1f9882d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@xmtp/react-native-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nplasterer nplasterer changed the base branch from main to np/rename-sender-address December 18, 2024 20:26
@nplasterer nplasterer requested a review from a team as a code owner December 18, 2024 20:27
Copy link

@mchenani mchenani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Base automatically changed from np/rename-sender-address to main December 18, 2024 20:34
@nplasterer nplasterer merged commit 5ddf56f into main Dec 18, 2024
5 of 6 checks passed
@nplasterer nplasterer deleted the np/client-create-perf branch December 18, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants